Make Stardoc work with --incompatible_enable_proto_toolchain_resolution. #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lberki
force-pushed
the
lberki-proto-toolchains
branch
from
05510e0
to
4cfb410
Compare
lberki
force-pushed
the
lberki-proto-toolchains
branch
from
4cfb410
to
b5da35e
Compare
fmeum
approved these changes
Jun 21, 2024
|
I'll wait for @tetromino , too |
|
Thanks for doing this migration! |
tetromino
approved these changes
Jun 21, 2024
|
D'oh! I actually deleted that file in one of the previous versions of this change, but managed to lost that in all the rebasing I did after :( |
tetromino
added a commit
to tetromino/stardoc
that referenced
this pull request
Jul 9, 2024
As the review of bazelbuild#241 showed, --incompatible_enable_proto_toolchain_resolution is not ready yet; we will re-add support for it in Stardoc when we no longer need to register our own protoc toolchain in Stardoc's MODULE.bazel file. The only parts of bazelbuild#237 we keep are the rules_jvm_external and rules_proto dep bumps; note that the rules_proto dep bump in turn requires a new dependency on bazel_features when using a Stardoc distro release with --noenable_blzmod.
tetromino
added a commit
that referenced
this pull request
Jul 17, 2024
As the review of #241 showed, `--incompatible_enable_proto_toolchain_resolution` is not ready yet; we will re-add support for it in Stardoc when we no longer need to register our own protoc toolchain in Stardoc's MODULE.bazel file. The only parts of #237 we keep are the rules_jvm_external and rules_proto dep bumps; note that the rules_proto dep bump in turn requires a new dependency on bazel_features when using a Stardoc distro release with `--noenable_blzmod.` Also revert most of #238 - we're no longer testing `--incompatible_enable_proto_toolchain_resolution`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.